[PATCH] Allow gitlab CI to pass without a private runner

Andrew Bartlett abartlet at samba.org
Wed May 2 10:22:30 UTC 2018


On Wed, 2018-05-02 at 12:39 +1200, William Brown wrote:
> On Tue, 2018-05-01 at 20:58 +1200, Andrew Bartlett wrote:
> > On Tue, 2018-05-01 at 08:26 +1200, Andrew Bartlett via samba-
> > technical
> > wrote:
> > > G'Day,
> > > 
> > > This patch splits up our gitlab CI configuration such that the
> > > tests
> > > that require a private runner (rather than the shared runners) do
> > > not
> > > operate by default.
> > > 
> > > The gitlab repositories that have access to a private runner can
> > > then
> > > use the .gitlab-ci-private.yml file via a config change.
> > > 
> > > This should make it easier for contributors to use gitlab.
> > > 

> > And now with the patch.
> 
> Applied, all builds/pipeline pass for me.
> 
> So I guess ... "review success". :) 
> 
Thanks William,

Can I have a team member review and push the patch into master please?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list