[PATCH] Allow gitlab CI to pass without a private runner
william at blackhats.net.au
Wed May 2 00:39:26 UTC 2018
On Tue, 2018-05-01 at 20:58 +1200, Andrew Bartlett wrote:
> On Tue, 2018-05-01 at 08:26 +1200, Andrew Bartlett via samba-
> > G'Day,
> > This patch splits up our gitlab CI configuration such that the
> > tests
> > that require a private runner (rather than the shared runners) do
> > not
> > operate by default.
> > The gitlab repositories that have access to a private runner can
> > then
> > use the .gitlab-ci-private.yml file via a config change.
> > This should make it easier for contributors to use gitlab.
> > The number of tests is not as good as on travis-ci, and we should
> > work
> > to split those that actually need ext4 out, but this is a step
> > forward
> > for now.
> > William,
> > Can you give this a test on your gitlab repo and confirm it passes
> > for
> > you?
> And now with the patch.
Applied, all builds/pipeline pass for me.
So I guess ... "review success". :)
More information about the samba-technical