[PATCH] samba-tool schema attribute query_oc

William Brown william at blackhats.net.au
Tue May 1 22:18:39 UTC 2018


On Tue, 2018-05-01 at 10:16 +0300, Alexander Bokovoy wrote:
> On ti, 01 touko 2018, William Brown via samba-technical wrote:
> > 
> > > 
> > > > 
> > > > May be the command would be 'show_oc' rather than 'query_oc' as
> > > > we
> > > > have
> > > > already a 'show' command. Just to reduce number of alternate
> > > > namings...
> > > 
> > > The alternate naming helps autocomplete, and also makes the
> > > command
> > > "unique". But I certainly also see your point to limit the
> > > "creep".
> > 
> > Ohh if I wasn't clear. I think the current name is good, but I can
> > change if it we really insist.
> 
> I'd like it changed, yes.
>  

Done! I have changed this for you and rerun the tests to assert it
worked.

Attaching the full patch series again so that it's easy to apply them
in order. I'll ask Andrew Bartlett to review these today also.

Thanks so much for your time Alex!

PS: these can also be found at: 
    https://github.com/Firstyear/samba/tree/configure

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-python-samba-netcmd-schema.py-add-schema-show_oc-for.patch
Type: text/x-patch
Size: 5094 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0006-python-samba-netcmd-schema.py-add-schema-show_oc-for.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-python-samba-netcmd-schema.py-add-schema-query-and-m.patch
Type: text/x-patch
Size: 14662 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0005-python-samba-netcmd-schema.py-add-schema-query-and-m.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-python-samba-netcmd-group.py-add-group-show.patch
Type: text/x-patch
Size: 6025 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0004-python-samba-netcmd-group.py-add-group-show.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python-samba-netcmd-domain.py-add-configuration-cont.patch
Type: text/x-patch
Size: 10025 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0003-python-samba-netcmd-domain.py-add-configuration-cont.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-samba-netcmd-forest.py-main.py-add-configurat.patch
Type: text/x-patch
Size: 11917 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0002-python-samba-netcmd-forest.py-main.py-add-configurat.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-samba-netcmd-dsacl.py-support-display-and-rem.patch
Type: text/x-patch
Size: 18786 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/bc36a1dd/0001-python-samba-netcmd-dsacl.py-support-display-and-rem.bin>


More information about the samba-technical mailing list