[PATCH] Fix strict aliasing warnings in ctdb_client

Amitay Isaacs amitay at gmail.com
Tue May 1 03:01:37 UTC 2018

On Mon, Apr 30, 2018 at 7:15 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> On Mon, Apr 30, 2018 at 6:49 PM, Stefan Metzmacher <metze at samba.org> wrote:
>> Am 30.04.2018 um 10:45 schrieb Amitay Isaacs via samba-technical:
>>> On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via
>>> samba-technical <samba-technical at lists.samba.org> wrote:
>>>> Hi,
>>>> see attached.
>>>> Review much appreciated.
>>> This is actually wrong.  It fixes the data format to LE, which will
>>> break things on BE machine.
>>> We need to fix the format for all the stored data and on-wire data.
>>> It might be better to change all the formats at once since it will
>>> break backward compatibility.
>> The function is actually not used and can be removed instead ...
> Sure.  I still wanted to point out what was wrong with the first patch.
> I am preparing a patch which drops most of the unused functions from
> ctdb_client.c.
> Andreas, please file CTDB bugs against CTDB component rather than Clustering.
> Amitay.

Here is a patch set that removes all of the unused code from ctdb_client.c.
ctdb_client.c is now moved to server/ subdirectory.  So all the old
style code now lives in server/.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 89876 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180501/63e0e9ae/ctdb.bin>

More information about the samba-technical mailing list