[PATCH] net: Add support for a credentials file

Andrew Bartlett abartlet at samba.org
Tue May 1 02:40:08 UTC 2018

On Tue, 2018-05-01 at 03:14 +0100, Olly Betts via samba-technical
> The attached patch extends net to support the same -A
> authfile/--authentication-file authfile option that most of the other
> tools already do.
> Patch is against current git master.
> Please review.

Thanks Olly,

I like the concept, but the addition of another parser for the file
worries me.

It would be better if it could either wrap or be wrapped by
cli_credentials_parse_file().  Ideally by adding
POPT_COMMON_CREDENTIALS to the popt table and reworking the code to use
it, just like client.c (for smbclient) does. 

I realise this is a lot more work, but we need to unify this rather
than see further parser proliferation. 


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list