[PATCH] Fix bug 13358 - open for delete on close without delete access can leave files around.
jra at samba.org
Thu Mar 29 15:39:18 UTC 2018
On Thu, Mar 29, 2018 at 01:45:03PM +0200, Volker Lendecke wrote:
> On Wed, Mar 28, 2018 at 02:07:56PM -0700, Jeremy Allison via samba-technical wrote:
> > Steve found an issue where creating files
> > with DELETE_ON_CLOSE requested but without
> > requesting DELETE access can leave "orphan"
> > files on the server (request fails, but
> > file is still created). It turns out we
> > had a test that this request fails, but
> > we weren't then checking that the file
> > hadn't been created.
> > I spent some time probing Windows to discover
> > how it behaves in these circumstances, and
> > coded the probes up as a set of regression
> > tests.
> > Here is the bugfix for Samba plus the regression
> > tests.
> > Please review and push if happy !
> Patch of course looks fine, RB+.
> One question thoug: Shouldn't we do test for SMB2 instead of SMB1?
> Eventually in a distant future we might remove SMB1, and all tests
> going in exclusively there will have to be ported.
Realisticly the SMB1 tests won't be going away for 5+
years, and so I'll migrate over that bridge when I
come to it :-).
On a more practical side, the initial test was already
there, just wrong, so it was easier to extend it.
More information about the samba-technical