[PATCH] Fix bug 13358 - open for delete on close without delete access can leave files around.

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 29 11:45:03 UTC 2018

On Wed, Mar 28, 2018 at 02:07:56PM -0700, Jeremy Allison via samba-technical wrote:
> Steve found an issue where creating files
> with DELETE_ON_CLOSE requested but without
> requesting DELETE access can leave "orphan"
> files on the server (request fails, but
> file is still created). It turns out we
> had a test that this request fails, but
> we weren't then checking that the file
> hadn't been created.
> I spent some time probing Windows to discover
> how it behaves in these circumstances, and
> coded the probes up as a set of regression
> tests.
> Here is the bugfix for Samba plus the regression
> tests.
> Please review and push if happy !

Patch of course looks fine, RB+.

One question thoug: Shouldn't we do test for SMB2 instead of SMB1?
Eventually in a distant future we might remove SMB1, and all tests
going in exclusively there will have to be ported.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list