[PATCH] Fix a warning in test_smb2_kernel_oplocks8

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 29 11:20:19 UTC 2018

On Thu, Mar 29, 2018 at 06:10:13PM +0800, Jones Syue via samba-technical wrote:
> Attached is a patch that fixes a warning in test_smb2_kernel_oplocks8,
> torture_assert_goto supposed to use '==' instead of '='.
> Please review & push. Thanks!

Patch is of course completely fine,

Reviewed-by: Volker Lendecke <vl at samba.org>

Stylistically I'd like to avoid "ret==true" and just replace it with
"ret" if "ret" is a boolean.

Would that be okay for you?

Thanks, Volker

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list