[PATCH] LMDB key value backend for ldb_tdb (to be renamed ldb_key_val)

Stefan Metzmacher metze at samba.org
Thu Mar 29 08:31:30 UTC 2018

Hi Gary,

This seems to be still some kind of work in progress, correct?
There're things like this:

+    else:
+        # TODO this should default to false in the final release
+        # REJECT if in final patch set
+        conf.env['ENABLE_LMDB'] = False

+ ... "Specify the database backend to be used TODO better words"

I'd also like to have this patchset rearranged, so that all generic
cleanups, like :
- introducing the 'ldb://' prefix
- adding new tests
- ldb: Change some prototypes to using ldb_val instead of TDB_DATA
- ldb: Change remaining fetch prototypes to remove TDB_DATA
come first.
- and more..
I don't understand the change from 'test.ldb' to 'sam.ldb'

Why is initialize_password_db() not within reinit_after_fork()?


Am 23.03.2018 um 02:00 schrieb Gary Lockyer via samba-technical:
> Updated patch set adding an lmdb backend to ldb, incorporating the
> feedback received to date. The patch set adds extra testing of the API
> and the new key value store layers.
> A lot of the names are still tdb specific.  Once these patches have
> landed on master, I'll put up patches that rename things sensibly.
> Please note that these patches can't be pushed until the lib-lmdb and
> lmdb-utils have been installed on sndevel.
> Comments and reviews greatly appreciated.
> Gary.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180329/81135843/signature.sig>

More information about the samba-technical mailing list