qsort_r() (was: Re: ldb and strict overflow)

Andrew Bartlett abartlet at samba.org
Wed Mar 28 01:19:37 UTC 2018

On Sat, 2018-03-24 at 09:15 +0100, Andreas Schneider wrote:
> The way the algorithm is implemented isn't really bad, just the code would 
> need more tests and then some real cleanup. The libc qsort in various 
> implementations have issues so it would be better to improve this algorithm 
> and put it in a common place. However this function is public API, we can't 
> really remove it.

Well, we can just leave it as a wrapper around qsort_r().  

Our copy was just taken (under licence) from libc anyway.

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list