talloc-2.1.12 issues with library destructor

[Ralph Böhme]

Hi Andreas,

On Mon, Mar 26, 2018 at 03:01:56PM +0200, Andreas Schneider via samba-technical wrote:
> destructors are normally executed after the program returns from main() or 
> after exit() is called. talloc tries to clean up its null context memory and 
> you have obviously a talloc destructor defined for your kcm_data talloc 
> context!
> 
> I don't thinks this is an issue in talloc, but sssd should cleanup the memory 
> in orderly_shutdown() before it calls exit()!

while I agree that we should work on deprecating and later removing
talloc_autofree, it's currently used and the recent change in commit
41b6810ba01f44537f470c806adb8686e1a39c48 in talloc which was aimed at fixing
long standing Samba bug 7587 seems to cause this regression.

We could try throwing destructor priorizy INT_MAX at the problem hoping noone
else uses such a high value.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46