[PATCH] Enforce strict overflow checking

Stefan Metzmacher metze at samba.org
Fri Mar 23 14:56:24 UTC 2018

Am 23.03.2018 um 15:36 schrieb Andreas Schneider via samba-technical:
> On Wednesday, 21 March 2018 18:26:04 CET Jeremy Allison wrote:
>> Andreas, I think you're going to have to work this
>> through on sn-devel first if it's going to go
>> through.
> OK, the attached patchset builds on sn-devel (gcc is more picky there) and a 
> private autobuild is currently running and more than 60% of the tests already 
> passed.
> The ldb_qsort was tricky so I wrote a test for it.
> I've set '-Wstrict-overflow=1' for bison generated getdate.c which uses C89 
> and our old nmbd code.

We can't add a hardcoded "-Wstrict-overflow=1" to every build.

We may have to just add -Wstrict-overflow=2 to PICKY_FLAGS,
so that this isn't added with 'allow_warnings=True'.

That would be a huge advantage already and makes sure we don't regress
in most of our code.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180323/7c9d60ed/signature.sig>

More information about the samba-technical mailing list