Python3 ports gpo
github at samba.org
github at samba.org
Fri Mar 23 13:17:52 UTC 2018
New comment by frenzymadness on Samba Github repository
https://github.com/samba-team/samba/pull/127#issuecomment-375661867
Comment:
Hello.
I did a quick review and I have two questions:
1. Why are you using global variables in the test? It's not necessary when you don't change variables content in a function/method. I tried it without the `global` and it works.
2. Shouldn't be `pyparam_util` defined as the dependency of libgpo with extended lib name? Example here: https://github.com/samba-team/samba/blob/da72c4018ed92feab28025f8c6c29894f4c8691c/lib/ldb-samba/wscript_build#L22
Thanks a lot for your work!
More information about the samba-technical
mailing list