[PATCH] Mention python versions in README.Coding
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Fri Mar 23 02:24:39 UTC 2018
Being compatible across versions 2.6 - 3.6 is an important thing for
Python contributors to think about, so we should mention it.
Also remove a reference to prog_guide4.txt, which disappeared a few
weeks ago.
Douglas
-------------- next part --------------
From 3099728d0999748b607b3b42c47c0d3b1d4fc01b Mon Sep 17 00:00:00 2001
From: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Fri, 23 Mar 2018 15:09:57 +1300
Subject: [PATCH 1/2] README.Coding: mention compatible Python versions
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
---
README.Coding | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/README.Coding b/README.Coding
index 054cf3f1079..fc807ef0f7b 100644
--- a/README.Coding
+++ b/README.Coding
@@ -22,9 +22,9 @@ closely matches what most Samba developers use already anyways, with a few
exceptions as mentioned below.
The coding style for Python code is documented in PEP8,
-http://www.python.org/pep/pep8 (with spaces).
-If you have ever worked on another free software Python project, you are
-probably already familiar with it.
+http://www.python.org/pep/pep8. New Python code should be compatible with
+Python 2.6, 2.7, and Python 3.4 onwards. This means using Python 3 syntax
+with the appropriate 'from __future__' imports.
But to save you the trouble of reading the Linux kernel style guide, here
are the highlights.
--
2.14.1
From 54c7177980749e4820801d7206502cdcf60f464f Mon Sep 17 00:00:00 2001
From: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Fri, 23 Mar 2018 15:12:06 +1300
Subject: [PATCH 2/2] README.Coding: remove reference to non-existent
prog_guide4.txt
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
---
README.Coding | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README.Coding b/README.Coding
index fc807ef0f7b..3d4c5a59e5d 100644
--- a/README.Coding
+++ b/README.Coding
@@ -16,10 +16,10 @@ style should never outweigh coding itself and so the guidelines
described here are hopefully easy enough to follow as they are very
common and supported by tools and editors.
-The basic style for C code, also mentioned in prog_guide4.txt, is the Linux kernel
-coding style (See Documentation/CodingStyle in the kernel source tree). This
-closely matches what most Samba developers use already anyways, with a few
-exceptions as mentioned below.
+The basic style for C code is the Linux kernel coding style (See
+Documentation/CodingStyle in the kernel source tree). This closely matches
+what most Samba developers use already anyways, with a few exceptions as
+mentioned below.
The coding style for Python code is documented in PEP8,
http://www.python.org/pep/pep8. New Python code should be compatible with
--
2.14.1
More information about the samba-technical
mailing list