[PATCH] Enforce strict overflow checking

Alexander Bokovoy ab at samba.org
Thu Mar 22 21:13:44 UTC 2018

On to, 22 maalis 2018, Andreas Schneider via samba-technical wrote:
> On Wednesday, 21 March 2018 18:26:04 CET Jeremy Allison via samba-technical 
> wrote:
> > Andreas, I think you're going to have to work this
> > through on sn-devel first if it's going to go
> > through.
> > 
> > I've re-pushed without the final patch that
> > turns on '-Werror=strict-overflow -Wstrict-overflow=2'.
> I'm still working on this and the gcc on sn-devel is much more picky than my 
> gcc.
> I'm attaching the latest patchset which still does not fully pass autobuild. 
> The current issue is that ancient getdate.y/getdate.c for vfs_readonly. I 
> wondered if running flex getdate.y would maybe produce and up to date version 
> which is compiler friendlier but I have no clue how this stuff really works.
> Alexander?
You can rebuild getdate.c with bison: bison -o getdate.c getdate.y
I tried rebuilding with F27's bison (3.0.4) and the only issue it found
was %pure_parser -- deprecated, should be %pure-parser (- versus _).

The generated getdate.c seems to be reasonable but a bit different in
how code is arranged. It needs to be tested more.

/ Alexander Bokovoy

More information about the samba-technical mailing list