[PATCH] Autobuild in about 3h30m

Andrew Bartlett abartlet at samba.org
Thu Mar 22 07:09:51 UTC 2018


On Thu, 2018-03-22 at 07:55 +0100, Stefan Metzmacher wrote:
> Am 22.03.2018 um 05:29 schrieb Andrew Bartlett via samba-technical:
> > As you would have followed, I've been playing with getting our
> > autobuild to be more parallel, based on some great work Jamie did over
> > the summer to remove the inter-dependencies. 
> > 
> > I've tested an earlier version of this on sn-devel (twice) and you can
> > see the CI status below:
> > 
> > https://gitlab.com/samba-team/samba/merge_requests/3
> > 
> > This is the same code as:
> > 
> > https://github.com/samba-team/samba/pull/148
> > 
> > Please carefully review as I've changed the environments some tests run
> > against to balance the test load.
> 
> As the nt4_* environments are split, would it still be possible to
> setup a trust between nt4_dc and ad_dc? E.g. if I make
> nt4_dc depend on ad_dc, the tests would still run in/against the nt4_dc
> environment, but an implicit ad_dc environment is created in the background?

Yes.  The split up is just in terms of what tests are called.  

> There were some threads regarding --without-ads build failures in the
> last weeks and maybe we already have a bug report, can you separate
> the build fixes, so that we can have them pushed directly
> and then fixed in 4.8.1?

Yes, there is another branch and patch set with those if it is easier
to start with them.  Andreas just pushed them.  

The build fixes are due to running with the picky developer stuff, end
users shouldn't hit them.

> The winbindd patches should also discussed separately,
> maybe Ralph has some comments there, because he recently fixed
> some retry logic.

OK.  I don't make winbindd changes often so a good eye here would be
most helpful.

> The trivial cleanups in the kerberos blackbox tests can also
> be pushed.

Thanks.

> The UTC changes seem to be fine as well and can be pushed.
> The clear enviromnent and wait_for_start changes as well.

Good.

> I would expect some '-' lines in the diff of
> "selftest: Run net.api.become.dc against less roles"

Yeah, what is going on there is that this was part of a loop further
up, which ran against more environments. 

Thanks so much for the comments!

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list