[PATCH] Help debugging SMB2 and SMB2 credits
slow at samba.org
Wed Mar 21 21:34:11 UTC 2018
On Wed, Mar 21, 2018 at 01:21:38PM -0700, Jeremy Allison wrote:
> On Wed, Mar 21, 2018 at 01:09:43PM -0700, Jeremy Allison wrote:
> > Hi all,
> > I am helping out a vendor who is having SMB2 crediting
> > issues (don't ask :-). One of the problems is that they
> > are flooded with debug level 10 logs trying to get the
> > data showing what the client is doing.
> > It turns out it wasn't too hard to add 2 new debug classes
> > that I think will be generally useful for all vendors.
> > So here is a small patchset that adds 2 new debug
> > classes, "smb2" and "smb2_credits", and marks the
> > relevent files/debug statements with them. This allows
> > the vendor to debug these issues separately.
> > Reviews welcome. Do we want this for 4.8.next ?
> > If so I'll log a bug report and back-port once
> > it's gone in (with bugID attached of course).
> > Cheers,
> > Jeremy.
> Updated version (I'd missed the debug statements
> in smbd_smb2_request_verify_creditcharge(), they're
> now tagged correctly as DBGC_SMB2_CREDITS).
the DBGC_* macros are a *really* nice addition, thanks! And we definitely want
this in 4.8 as well, so I haven't push the patchset as it, but instead file this
If you agree, please push the patches with my thumbs-up after adding the bug
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
More information about the samba-technical