Fwd: [PATCHES] simple gpo patches fixes

David Mulder dmulder at suse.com
Wed Mar 21 12:55:38 UTC 2018


Oh, shoot. I know better than to do that (I was lecturing someone else
about this recently).
I just copy and pasted from another function in that file without
thinking. I'll definitely get that fixed.

On 03/20/2018 07:07 PM, Garming Sam wrote:
> Can you put braces around this? Looks like the whole file is full of
> this (and other coding style violations), I'll perhaps try and fix the
> rest of them later myself.
> +	if (!PyArg_ParseTuple(args, "s", &name))
> +		return NULL;
>
>
> Otherwise,
>
> Reviewed-by: Garming Sam <garming at catalyst.net.nz>
>
> Can someone else please review this as well?
>
>
> Cheers.
>
>
> On 21/03/18 02:55, David Mulder wrote:
>> I've attached a new set of patches that use lpcfg_cache_path() to ensure
>> the cache directory exists with the correct permissions.
>>
>> On 03/19/2018 03:44 PM, Garming Sam wrote:
>>> Hi David,
>>>
>>> Yes, that seems fine. The rest of the code internally seems to do much
>>> the same with 0755 for any subdirectories. Neither xx_path nor the
>>> lpcfg_common_path do the right thing in either case and it doesn't
>>> seem to be worth changing that behaviour. I was mostly just concerned
>>> about the top level cache path.
>>>
>>> Cheers,
>>>
>>> Garming
>>>
>

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)



More information about the samba-technical mailing list