CTDB: Patch set re-based because of updates

Martin Schwenke martin at meltin.net
Wed Mar 21 11:30:39 UTC 2018


On Wed, 21 Mar 2018 08:46:36 +0100, Swen Schillig <swen at vnet.ibm.com>
wrote:

> On Wed, 2018-03-21 at 16:54 +1100, Martin Schwenke wrote:
> > On Tue, 20 Mar 2018 08:00:34 +0100, Swen Schillig <swen at vnet.ibm.com>
> > wrote:
> > 
> > Oops.  The last commit doesn't move the DLIST_ADD_END() but it
> > inserts
> > an additional use of that macro.  I think this was correct in an
> > earlier
> > version but must have got lost in the rebase.  :-(
> >   
> 
> Good catch !
> 
> Updated.

This will eventually kill us...

In commit 6, the definition of ctdb_start_revoke_ro_record() has been
wrapped but had more than 1 parameter per line.  Also the call to
ctdb_revoke_all_delegations() also has more then 1 parameter per line.

With those 2 changes:

Reviewed-by: Martin Schwenke <martin at meltin.net>

I'm happy for a 2nd reviewer to jump in if you resend with those
changes.

Thanks...

peace & happiness,
martin



More information about the samba-technical mailing list