[PR PATCH] [Updated] Python3 misc bugfixes

[Noel Power]

Hi Joe,


On 20/03/18 23:33, joeg at catalyst.net.nz wrote:
>
> Hi Noel and Douglas,
>
> I was also working on this one yesterday.
>
> Both of your changes are good to me in logic.
>
> To merge my contribution, I made a new patch based on yours with small
> improvements:
>
> 1. Merge tests for different formats into one test with for loop, make
> it easy to read and extend.
>
Personally I prefer the individual tests, I find the output of sefltest
a little hard to grok (lots of noise) so I like to (where possible) be
able to identify what is failing with least effort. othoh this is easier
to extend so I would not really object on that basis.
>
> 2. Add test for invalid formats.
>
good idea

Thanks,

Noel
>
> Hope this is fine to you!
>
>
> On 21/03/18 10:48, Douglas Bagnall via samba-technical wrote:
>> On 08/03/18 10:15, Github bot account via samba-technical wrote:
>>> There is an updated pull request by noelpower against master on the Samba Samba Github repository
>>>
>>> https://github.com/noelpower/samba python3-misc-bugfixes
>>> https://github.com/samba-team/samba/pull/138
>>>
>>> Python3 misc bugfixes
>>>
>> Noel,
>>
>> I think we should have the additional test in the last of these patches
>> squashed into your test patch.
>>
>> It checks that the long-form bytes GUID is equal to the long-form string
>> GUID.
>>
>> cheers,
>>
>> Douglas
>
> -- 
> Joe Guo
> joeg at catalyst.net.nz
> Catalyst IT