[PATCH] Python 3 porting for selftest.ndrdump

joeg at catalyst.net.nz joeg at catalyst.net.nz
Wed Mar 21 01:41:28 UTC 2018

Hi everyone:

I am going to focus on the Python 3 porting task for 2 weeks or so.

I was a Python Web developer before.  In this context, most of my
knowledge are about Python,

and I don't know too much about Samba internal yet.

To make this Python 3 porting task measurable and operational to me,
after a discussion with

Andrew Bartlett, I decided to carry on it via selftest:

0.  Configure samba with `--extra-python /path/to/python3`

1.  Find a test suite in selftest/tests.py,  add `py3_compatible=True`.

2. Run above test suite, and fix errors.

3. Send patch to email list.

4. Move on to next one.

This is the first patch, for `samba.tests.blackbox.ndrdump`, and it's

In the meanwhile, I will work on next ones and send follow-up patches.

Let's see whether this strategy works well.

Review appreciated. Thanks!

Joe Guo

Joe Guo
joeg at catalyst.net.nz
Catalyst IT

-------------- next part --------------
A non-text attachment was scrubbed...
Name: py3-ndrdump.patch
Type: text/x-patch
Size: 1774 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180321/22a60ff1/py3-ndrdump.bin>

More information about the samba-technical mailing list