Fwd: [PATCHES] simple gpo patches fixes

Garming Sam garming at catalyst.net.nz
Wed Mar 21 01:07:55 UTC 2018

Can you put braces around this? Looks like the whole file is full of
this (and other coding style violations), I'll perhaps try and fix the
rest of them later myself.

+	if (!PyArg_ParseTuple(args, "s", &name))
+		return NULL;


Reviewed-by: Garming Sam <garming at catalyst.net.nz>

Can someone else please review this as well?


On 21/03/18 02:55, David Mulder wrote:
> I've attached a new set of patches that use lpcfg_cache_path() to ensure
> the cache directory exists with the correct permissions.
> On 03/19/2018 03:44 PM, Garming Sam wrote:
>> Hi David,
>> Yes, that seems fine. The rest of the code internally seems to do much
>> the same with 0755 for any subdirectories. Neither xx_path nor the
>> lpcfg_common_path do the right thing in either case and it doesn't
>> seem to be worth changing that behaviour. I was mostly just concerned
>> about the top level cache path.
>> Cheers,
>> Garming

More information about the samba-technical mailing list