[PR PATCH] [Updated] Python3 misc bugfixes

joeg at catalyst.net.nz joeg at catalyst.net.nz
Tue Mar 20 23:33:11 UTC 2018

Hi Noel and Douglas,

I was also working on this one yesterday.

Both of your changes are good to me in logic.

To merge my contribution, I made a new patch based on yours with small

1. Merge tests for different formats into one test with for loop, make
it easy to read and extend.

2. Add test for invalid formats.

Hope this is fine to you!

On 21/03/18 10:48, Douglas Bagnall via samba-technical wrote:
> On 08/03/18 10:15, Github bot account via samba-technical wrote:
>> There is an updated pull request by noelpower against master on the Samba Samba Github repository
>> https://github.com/noelpower/samba python3-misc-bugfixes
>> https://github.com/samba-team/samba/pull/138
>> Python3 misc bugfixes
> Noel,
> I think we should have the additional test in the last of these patches
> squashed into your test patch.
> It checks that the long-form bytes GUID is equal to the long-form string
> cheers,
> Douglas

Joe Guo
joeg at catalyst.net.nz
Catalyst IT

-------------- next part --------------
A non-text attachment was scrubbed...
Name: py3-guid-patch-v2.patch
Type: text/x-patch
Size: 11840 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180321/f93f1173/py3-guid-patch-v2.bin>

More information about the samba-technical mailing list