[PATCH] ms_schema: fix python2.6 incompatibility

Bjoern Baumbach bb at sernet.de
Tue Mar 20 12:16:24 UTC 2018


On 03/16/2018 06:03 AM, Andrew Bartlett wrote:
> On Fri, 2018-03-16 at 11:54 +1300, Douglas Bagnall via samba-technical
> wrote:
>>
>> Sorry. They are all correct. I meant it when I said RB+.
> 
> Attached is the patch with my review also, and the bug.  Please push it
> with a fix for the other issue mentioned on the bug so it can be
> backported for 4.8.1.

Thank you for the review and the explanations. I'll attach the patch to
the bug.

Since there is a very similar issue in the visualize.py code, I've
renamed the bug and attached an additional patch, which solves the issue.
If the attached patch is fine, I would use both patches to fix the bug.

Best regards,
Björn

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-visualize-fix-python2.6-incompatibility.patch
Type: text/x-patch
Size: 1115 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180320/1c5258ee/0001-samba-tool-visualize-fix-python2.6-incompatibility.bin>


More information about the samba-technical mailing list