[PATCH] ctdb-server: Remove one-line goto

Swen Schillig swen at vnet.ibm.com
Mon Mar 19 08:28:59 UTC 2018

On Mon, 2018-03-19 at 16:30 +1300, Andrew Bartlett wrote:
> On Fri, 2018-03-16 at 10:32 -0700, Jeremy Allison via samba-technical
> wrote:
> > 
> > 
> > Please bear with us, we (mostly:-) are really nice
> > people and we'd love to help you help us - with the
> > ultimate goal of adding you to the Team so you can
> > be a nice person yourself :-) :-).

Ohh, I'm already such nice person :-)
> I'm mostly nice too :-).  I think they other point that was missed
> above is that the Samba Team is, for better or worse, conservative.  
> Finally, I would say take it a bit more easy on the borderline
> patches.
>  Things like "[PATCH] ctdb-server: Add goto tag avoiding code
> duplication" as a case in point.  Both approaches are equally ugly,
> and
> equally common in Samba, and when you have 20 patch threads on the go
> it becomes easier for folks to throw up their hands and just ignore
> it
> than dive in and look into it.
Well, I'm not trying to justify myself here, but as I said before, 
this mass-annoying-patch-set was originally consisting of 3 or 4
patches and not 12-15 or so. 
So I thought that was easier to digest but I was told to not do that.

I guess I will leave any of those so-called "cleanup's" for a while and
focus on the bare fix.
....waiting for the "while at it you could.." comments.

Thanks Andrew, Jeremy for your help.

Cheers Swen

More information about the samba-technical mailing list