[PATCH] Second part of bugfix for bug #13319 (round-tripping ACE's through vfs_fruit).
jra at samba.org
Fri Mar 16 18:47:09 UTC 2018
On Fri, Mar 16, 2018 at 07:34:54PM +0100, Ralph Böhme wrote:
> Hi Jeremy,
> On Thu, Mar 15, 2018 at 03:28:03PM -0700, Jeremy Allison wrote:
> > On Thu, Mar 15, 2018 at 06:15:04PM -0400, jim via samba-technical wrote:
> > > Should vfs_fruit.c debug message use DEBUG_WARNING instead of DEBUG(1, per
> > > replaced code?
> > Yes, that's correct, I missed that. Updated patch attached.
> thanks! Lgtm. Sorry for not catching this in the initial review.
Is that lgtm a RB+ ? Just checking :-).
> Once question: why do you add a new share and test-suite for the test? The
> option is enabled by default, so we shouldn't need this unless you wanted to
> make this explicit in case the default changes.
The default share doesn't have xattr_tdb on the end of
the vfs modules. It it gets run on a filesystem that
doesn't support native xattrs the test fails (took
me a long time to figure out why running it manually
worked - ext4, vs running make test failed - tmpfs :-).
I didn't want to add that to the "standard" vfs_fruit
share just in case this was intentional or caused
other tests to fail.
More information about the samba-technical