[PATCH] Second part of bugfix for bug #13319 (round-tripping ACE's through vfs_fruit).

Ralph Böhme slow at samba.org
Fri Mar 16 18:34:54 UTC 2018


Hi Jeremy,

On Thu, Mar 15, 2018 at 03:28:03PM -0700, Jeremy Allison wrote:
> On Thu, Mar 15, 2018 at 06:15:04PM -0400, jim via samba-technical wrote:
> > Should vfs_fruit.c debug message use DEBUG_WARNING instead of DEBUG(1, per
> > replaced code?
> 
> Yes, that's correct, I missed that. Updated patch attached.

thanks! Lgtm. Sorry for not catching this in the initial review.

Once question: why do you add a new share and test-suite for the test? The
option is enabled by default, so we shouldn't need this unless you wanted to
make this explicit in case the default changes.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46



More information about the samba-technical mailing list