[PATCH] Remove several CTDB configuration/daemon options

[Martin Schwenke]

This patch set drops the following CTDB configuration variables and
corresponding ctdbd command-line options:

  CTDB_PIDFILE            --pidfile
  CTDB_SOCKET             --socket
  CTDB_NODES              --nlist
  CTDB_PUBLIC_ADDRESSES   --public-addresses
  CTDB_EVENT_SCRIPT_DIR   --event-script-dir
  CTDB_PUBLIC_INTERFACE   --public-interface

Also dropped are the:

  ctdb command's --socket command-line option
  ctdb command's CTDB_NODES environment variable
  onnode command's CTDB_NODES_FILE environment variable
  10.external event script (unused)
  Internal CTDBD_CONF test variable (now unused)

Analysis:

* CTDB has too many unneccessary moving parts

* In coming months failover handling will be rewritten, so
  CTDB_PUBLIC_ADDRESSES and CTDB_PUBLIC_INTERFACE won't be missed.

* In future there will be more than one directory containing event
  scripts, so having a single option doesn't make a lot of sense.

* PID file should always be the compile-time default

  For testing we use an environment variable (CTDB_PIDFILE) to specify
  an alternative location

* Socket location should always be the compile-time default

  For testing we use an environment variable (CTDB_SOCKET) to specify
  an alternative location

* The following should always be in the compile-time default
  configuration directory:

  - nodes
  - public_addresses
  - events.d/

  For testing we override the location of the configuration directory
  via an internal environment variable (CTDB_BASE)

  Use a symbolic link from the configuration directory to specify a
  different location for nodes or public_addresses (e.g. in the
  cluster filesystem).

* Interfaces for public IP addresses must always be specified in the
  public_addresses file using the currently supported format

* onnode still has a -f option for specifying an alternative nodes file

About 1/2 of the commits are supporting changes in the test code.

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 115768 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180316/7f919209/ctdb-0001.bin>