[PATCH] ctdb-server: Remove one-line goto

Andrew Bartlett abartlet at samba.org
Thu Mar 15 18:41:32 UTC 2018

On Thu, 2018-03-15 at 09:17 +0100, Swen Schillig via samba-technical
> More thoughts ?
> Cheers Swen.

My main thought is that reformatting code to README.Coding should be
done with care and great thought. 

There is much non-compliant code in Samba and while that isn't a great
situation we have not chosen so far to do a wholesale reformat. 

In particular changes like this consume abnormal amounts of review
resources and attract bike-shedding, dragging in even more folks to the

They are also more risky than you might expect, because this is the
single easiest way to introduce a regression, as it is 'only'
reformatting, but actually changes the control flow.

Your attention on Samba is most welcome, but I we are over-flowing with
end-user visible bugs, perhaps you could help with some of those, or
(at the more mechanical but valuable) the Python2->Python3 conversion?


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list