[PATCH] s3:smbd: map nterror on smb2_flush errorpath

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 15 11:44:16 UTC 2018


Reviewed-by: Volker Lendecke <vl at samba.org>

Another team review?

Thanks, Volker

On Thu, Mar 15, 2018 at 02:38:41PM +0300, Anton Nefedov via samba-technical wrote:
> smbd_smb2_flush_recv() expects nterror in tevent_req, and otherwise
> aborts in tevent_req_is_nterror()
> 
> Signed-off-by: Anton Nefedov <anton.nefedov at virtuozzo.com>
> ---
>  source3/smbd/smb2_flush.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/smbd/smb2_flush.c b/source3/smbd/smb2_flush.c
> index d077c62..51584ca 100644
> --- a/source3/smbd/smb2_flush.c
> +++ b/source3/smbd/smb2_flush.c
> @@ -198,7 +198,7 @@ static void smbd_smb2_flush_done(struct tevent_req *subreq)
>  	ret = SMB_VFS_FSYNC_RECV(subreq, &vfs_aio_state);
>  	TALLOC_FREE(subreq);
>  	if (ret == -1) {
> -		tevent_req_error(req, vfs_aio_state.error);
> +		tevent_req_nterror(req, map_nt_error_from_unix(vfs_aio_state.error));
>  		return;
>  	}
>  	tevent_req_done(req);
> -- 
> 2.7.4
> 
> 

-- 
Besuchen Sie die verinice.XP 2018 in Berlin,
Anwenderkonferenz für Informationssicherheit
vom 21.-23.03.2018 im Sofitel Kurfürstendamm
Info & Anmeldung hier: http://veriniceXP.org

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list