[PATCH] ctdb-server: Remove one-line goto

Martin Schwenke martin at meltin.net
Thu Mar 15 01:06:31 UTC 2018

On Fri, 09 Mar 2018 09:15:38 +0100, Swen Schillig via samba-technical
<samba-technical at lists.samba.org> wrote:

> Please review and push if OK.

I *think* this goes goes against the "Error and out logic" section of
README.Coding.  I'm not sure because that section only has a single
illustrative example.  So, I'm not sure whether an error-and-out with a
goto to avoid a single line of code is better or worse than using an
else.  ;-)

Does anyone else have an opinion?

peace & happiness,

More information about the samba-technical mailing list