[PATCH] samba-tools: add computer subcommand

joeg at catalyst.net.nz joeg at catalyst.net.nz
Wed Mar 14 22:56:17 UTC 2018


Hi Bjoern,

Thank you for making the samba-tools computer patch.

According to Andrew and Garming's advice, I extract some of the
functions in my previous patch, and created a new patch based on yours:

1. Add `--ip-address` option for the create subcommand, to allow user
set DNS A or AAAA records while creating the computer.
2. Delete above DNS records while deleting the computer.
3. Add `--service-principal-name` option for the create command, to
allow user set `servicePrincipalName` while creating the computer.
4. Tests.

Could you or any one else review this patch? Any feedback are welcome
and appreciated!

Joe Guo


On 09/03/18 21:16, Andrew Bartlett via samba-technical wrote:
> On Tue, 2018-03-06 at 11:16 +0100, Bjoern Baumbach wrote:
>> On 03/06/2018 09:20 AM, Andrew Bartlett wrote:
>>> Did you ever make any progress on this?
>> Hi Andrew,
>>
>> I was busy with other things. Thank you for the reminder. I've just
>> fixed a few things to provide the first basic version (attached to this
>> mail). Hope it helps so far. The newcomputer() function would need to be
>> extended, but should be sufficient for a basic functionality
>>
>> The documentation will also follow later.
> Thank you very much.  This is on my list to look into and integrate
> early next week.
>
> Andrew Bartlett

-- 
Joe Guo
joeg at catalyst.net.nz
Catalyst IT

-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba-tools-computer-improve.patch
Type: text/x-patch
Size: 52124 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180315/444db418/samba-tools-computer-improve.bin>


More information about the samba-technical mailing list