[Fwd: Re: [PATCH] s3: Fix max indentation and max column]

Uri Simchoni uri at samba.org
Sat Mar 10 05:15:36 UTC 2018

On 03/09/2018 11:48 PM, Jeremy Allison wrote:
> On Wed, Mar 07, 2018 at 08:27:50PM +0200, Uri Simchoni wrote:
>> On 03/07/2018 07:16 PM, Jeremy Allison via samba-technical wrote:
>>> In the meantime I'll work on getting README.Coding changed
>>> so the "correct" way of parameter passing is preferred :-).
>>> Cheers,
>>> 	Jeremy.
>> How about this change (writing this in the interest of keeping the
>> coding style roughly clang-formattable...)?
> Looks good to me ! Want to send it as a git-format patch ?

-------------- next part --------------
From 612578930f38c9cadfc8ed9730f84d7ae0e451a1 Mon Sep 17 00:00:00 2001
From: Uri Simchoni <uri at samba.org>
Date: Sat, 10 Mar 2018 07:08:28 +0200
Subject: [PATCH] README.Coding: codify line splitting on function calls

Signed-off-by: Uri Simchoni <uri at samba.org>
 README.Coding | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.Coding b/README.Coding
index e89925cad26..054cf3f1079 100644
--- a/README.Coding
+++ b/README.Coding
@@ -99,6 +99,7 @@ BreakBeforeBraces: Linux
 AllowShortIfStatementsOnASingleLine: false
 IndentCaseLabels: false
 BinPackParameters: false
+BinPackArguments: false
@@ -201,8 +202,8 @@ parameters across lines and not as encourage for gratuitous line
 splitting.  Never split a line before columns 70 - 79 unless you
 have a really good reason. Be smart about formatting.
-One exception to the previous rule is function declarations and
-definitions. In function declarations and definitions, either the
+One exception to the previous rule is function calls, declarations, and
+definitions. In function calls, declarations, and definitions, either the
 declaration is a one-liner, or each parameter is listed on its own
 line. The rationale is that if there are many parameters, each one
 should be on its own line to make tracking interface changes easier.

More information about the samba-technical mailing list