[Fwd: Re: [PATCH] s3: Fix max indentation and max column]
jra at samba.org
Wed Mar 7 17:06:16 UTC 2018
On Wed, Mar 07, 2018 at 08:53:39AM +0100, Swen Schillig via samba-technical wrote:
> On Tue, 2018-03-06 at 15:22 -0800, Jeremy Allison wrote:
> > when reformatting. When calling a function one paramter per line is *much* easier to
> > read and modify than multiple paramerers per-line.
> > This is because if you need to change one parameter later, it makes it extremely
> > clear what it is you are changing in a future patchset.
> > I know it seems overly picky, but I'd like to NAK until I see a version
> > that looks like:
> > > + dptr->dir_hnd = OpenDir(NULL,
> > > + dptr->conn,
> > > + dptr->smb_dname,
> > > + dptr->wcard,
> > > + dptr->attr);
> > instead. It's very close to being right, I want to make the
> > patch be beautiful as well :-) :-).
> Well, you know how it is, beauty depends on the viewer :-)
> but here I'm afraid I would code against the SAMBA Coding rules if I'd
> do it the way you want.
Well the Samba coding rules are wrong in this case then :-).
More information about the samba-technical