[PATCH] Add missing break in ldb

Andrew Bartlett abartlet at samba.org
Mon Mar 5 08:12:27 UTC 2018


On Mon, 2018-03-05 at 09:02 +0100, Andreas Schneider wrote:
> On Monday, 5 March 2018 08:57:55 CET Andrew Bartlett wrote:
> > On Mon, 2018-03-05 at 08:47 +0100, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > Hi,
> > > 
> > > just after my patchset for -Wimplicit-fallthrough landed it already
> > > reported a new bug!
> > > 
> > > If you have gcc 7 or newer running, please make sure to rerun configure
> > > that the flag is detected and turned on!
> > > 
> > > 
> > > Please review and push if OK.
> > 
> > EWRONGPATCH?
> 
> Yes, correct one attached :-)

Thanks, that was my bad.  Actually I think we should return
ldb_operr(ldb).  Ideally we would have some compiler-level way of
saying this is an invalid/unreachable switch branch but that is a
little hard in C.

Thankyou!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list