[PATCH] Add thread safety to socket_wrapper

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 1 09:35:26 UTC 2018

On Thu, Mar 01, 2018 at 01:51:39PM +0530, Anoop C S via samba-technical wrote:
> I have made changes accordingly. See the attached patch set.

Thanks for that change!

Small nit-pick: A boolean indicating +1 or -1 swrap_alter_refcount
obscures the callers. Can we either make that two functions like
swrap_inc/dec_refcount or make the parameter an integer like +1/-1.
This would make the callers much more obvious.


Besuchen Sie die verinice.XP 2018 in Berlin,
Anwenderkonferenz für Informationssicherheit
vom 21.-23.03.2018 im Sofitel Kurfürstendamm
Info & Anmeldung hier: http://veriniceXP.org

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list