[PATCH] smb3: simplify code by removing CONFIG_CIFS_SMB311

Steve French smfrench at gmail.com
Fri Jun 29 02:48:06 UTC 2018


On Thu, Jun 28, 2018 at 7:41 PM Ronnie Sahlberg <lsahlber at redhat.com> wrote:
>
> I am all for removing the 311 config option.
>
> The wording in Kconfig though :
> +      The SMB3 (and now SMB3.11) protocol is supported by most modern
>
> Do we really need to call out specific smb3 dialects explicitly here?
> It sounds like something we will need to keep changing as new dialects come out.
>
> Can't we just refer to SMB3  and assume that 311 is part of that?
>
> I.e.
> +      The SMB3 protocol is supported by most modern

That is an interesting question - SMB3.1.1 is extensible (ie negotiate
and tree connect contexts)
so in theory it shouldn't be required to add a new dialect every few
years anymore, but my
bigger reason for this is to **strongly** emphasize SMB3.1.1 due to
some VERY useful security
features in it (and eventually for the ability to do POSIX extensions
to Samba etc.).  Many
people probably don't know the advantages of SMB3.1.1 and I wanted to
hammer that
point home in this era when everyone seems to be worried about CIFS
security holes and
forgetting the excellent work that was done on SMB3.1.1 (even beyond what was in
SMB3).

-- 
Thanks,

Steve



More information about the samba-technical mailing list