[PATCH] Dependent changes for rename tool

Andrew Bartlett abartlet at samba.org
Thu Jun 28 03:25:24 UTC 2018

On Thu, 2018-06-28 at 15:07 +1200, Tim Beale via samba-technical wrote:
> Hi,
> Attached are the first few 'pre-work' patches for the backup-rename tool
> (the rename tool is dependent on these changes, but this patch-set
> doesn't include the rename tool itself). These changes mostly try to
> tidy up the join.py clone code so that it's simpler to re-use. These are
> ready for review and delivery.
> Clean CI results here:
> https://gitlab.com/catalyst-samba/samba/pipelines/24718107
> Branch also here:
> https://gitlab.com/catalyst-samba/samba/commits/tim-rename-set1
> Review appreciated.

Thanks.  Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Thanks for taking a fresh eye to the hacks on hacks that had
accumulated in join.py

Can I get a second team review please?


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list