[PATCH] Domain backup and restore samba-tool commands
Andrew Bartlett
abartlet at samba.org
Thu Jun 28 01:34:17 UTC 2018
On Thu, 2018-06-28 at 13:10 +1200, Douglas Bagnall via samba-technical
wrote:
> On 28/06/18 10:20, Tim Beale wrote:
>
> > Hi Douglas,
> >
> > I've:
> > - Fixed whitespace in #3
> > - Added return value checks in #2
> > - Also initialized pointers to NULL in #2
> > - Also tweaked the following logic in #2 (it didn't look quite right to me)
> > + if (ret != LDB_SUCCESS || res == NULL || res->count == 0) {
> > + talloc_free(db_context);
> > + return ret;
> > + }
>
> Yep, that looks better.
>
> Reviewed as attached, with the following changes squashed in.
Thanks Douglas,
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Pushed to autobuild.
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list