[PATCHES] rename samba_gpoupdate to gpupdate

David Mulder dmulder at suse.com
Wed Jun 27 13:22:44 UTC 2018


Obviously the rename is a trivial thing. Naming it samba_gpupdate does
seem to make more sense.
I would like to make the parameter change though. The current param of
--machine for computer apply, and lack of --machine meaning user apply
is awkward.

On 06/26/2018 08:07 PM, Andrew Bartlett wrote:
> On Thu, 2018-06-07 at 11:07 +0200, David Mulder via samba-technical
> wrote:
>> This command is called gpupdate on Windows, and uses a target parameter
>> to determine Computer/User apply. Let's mimic that command.
>>
>>  docs-xml/smbdotconf/domain/gpoupdatecommand.xml                 |  4 ++--
>>  lib/param/loadparm.c                                            |  2 +-
>>  selftest/target/Samba4.pm                                       |  2 +-
>>  source3/param/loadparm.c                                        |  2 +-
>>  source3/winbindd/winbindd_gpupdate.c                            |  2 +-
>>  source4/scripting/bin/{samba_gpoupdate => gpupdate}             | 12
>> ++++++------
>>  source4/scripting/bin/wscript_build                             |  2 +-
>>  source4/scripting/man/{samba_gpoupdate.8.xml => gpupdate.8.xml} | 13
>> ++++++++-----
>>  source4/scripting/wscript_build                                 |  4 ++--
>>  9 files changed, 23 insertions(+), 20 deletions(-)
> G'Day David,
>
> I understand the desire not to have the "o" in there, but why remove
> the samba_ prefix?
>
> I'm nervous about the mimic idea, because we tried that with 'net'
> which doesn't really mimic Windows very well and instead diverges at
> lot.  (Whereas samba-tool has no pretence as to what it is).
>
> Andrew Bartlett
>

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)




More information about the samba-technical mailing list