[PATCH] Domain backup and restore samba-tool commands

[Andrew Bartlett]

On Wed, 2018-06-27 at 09:13 +1200, Tim Beale via samba-technical wrote:
> Hi,
> 
> Attached is the latest patches for the backup/restore tool Aaron has
> been working on. It's still not quite 100% complete, but it's getting close.
> 
> We've dropped the offline backup command for now (i.e. the option that
> just tarred up the raw files on disk). There were still a few
> outstanding issues with it, the main one being that it didn't support
> LMDB at all. We'll address this once the backup-online, restore, and
> backup-rename work is in master.
> 
> We've now added a sub-set of tests that run over a restored DC. Clean CI
> results here:
> https://gitlab.com/catalyst-samba/samba/pipelines/24560305
> 
> The main outstanding work is just a few more tidy ups to the code, and
> to integrate the backup tool with the NTACL changes Joe is working on.
> 
> Git branch also available here:
> https://gitlab.com/catalyst-samba/samba/tree/tim-backup-tool

Thanks Tim,

I'm concerned by the dns_backend="NONE".  Are we sure (and can we
prove) that this is still backing up the DNS partitions?

I would also skip the local kerberos tests (the ones doing local gensec
operations) and leave those for the offline backup test (where they
have a hope of working). 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba