[PATCH] don't enable wins dns proxying by default
abartlet at samba.org
Tue Jun 26 20:24:22 UTC 2018
On Tue, 2018-06-26 at 10:43 +0200, Björn JACKE via samba-technical
> On 2018-06-26 at 20:14 +1200 Andrew Bartlett sent off:
> > On Tue, 2018-06-26 at 09:53 +0200, Björn JACKE via samba-technical
> > wrote:
> > > On 2018-06-26 at 05:39 +1200 Andrew Bartlett via samba-technical sent off:
> > > > On Mon, 2018-06-25 at 13:31 +0200, Björn JACKE via samba-technical
> > > > wrote:
> > > > > please review and push eventually
> > > >
> > > > Now I realise you are just trying to provoke a discussion,
> > >
> > > I have no idea what you mean with that, can you write in better words?
Sorry for the terse reply. The patch itself was (is) very terse as to
the rationale, as the phrasing seemed like you were not so much looking
for it to be pushed as to start a discussion as to if we wish to do
So, what I meant was 'I've added an imaginary [WIP] to this patch set
in my head. Assuming that was correct could you please think about
these things in making your final patch'.
> > >
> > > > but I would
> > > > have expected a default value change to need to have the smb.conf
> > > > manpage updated and the source3 defaults changed.
> > >
> > > the man page is updated automatically along with the default parameters IIRC,
> > > if for some reason it is not in this case, let me know, I'd be happy to fix
> > > that then
> > >
> > > > (The tests should have picked this up, if you did a test run please let
> > > > me know so we can investigate).
> > >
> > > "the test should have picked this up" - again I don't get what you want to say.
> > G'Day Björn,
> > Perhaps submit the patch to the GitLab CI and see what happens.
> Hi Andrew, can you answer my question and clarify the words from your previous
> mail please?
As Ralph as mentioned, Samba actually has comprehensive tests for
correctness of defaults and to ensure they match between the manpages,
lib/param and source3/param systems.
What I was trying to say (obliquely) is that it looks like you hadn't
run make test or autobuild on this, and so I suggested that you might
want to use GitLab CI as a easy way to do that, and so see the errors
As that would sound like an accusation, I then couched my answer to say
that if you had indeed run a full make test, to please do let me know
because I think it should have failed on that patch.
Finally, I agree I was very abrupt, and should not have made a reply
when so tired.
I hope this helps clarify things,
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical