[PATCH] don't enable wins dns proxying by default

[Andrew Bartlett]

On Tue, 2018-06-26 at 12:28 +0200, Ralph Böhme via samba-technical
wrote:
> On Tue, Jun 26, 2018 at 11:47:38AM +0200, Björn JACKE via samba-technical wrote:
> > On 2018-06-25 at 13:31 +0200 Björn JACKE via samba-technical sent off:
> > > please review and push eventually
> > 
> > attached the patch with the docu reflecting the changed default also and
> > another man page fix.
> 
> I guess the two patches should be squashed, otherwise bisecting breaks if you
> happen to stop at the first one.
> 
> autobuild has tests that verify that the XML defaults match the values set in
> lib/param/loadparm.c, so with only your first patch applied, there's a mismatch
> and the autobuild will fail. :)

The code is quite comprehensive, so it also checks that the
source3/param/loadparm.c code also matches. 

This is a good advertisement for CI.  

Björn, can you set up an account on gitlab.com and let me know the
username?  While it isn't perfect (yet), the CI runner there does a
really good, and most importantly lightweight to the developer, job of
picking up this kind of stuff without having to wait for jet-lagged
Australians to reply.

Once you have an account, you can push to the shared

https://gitlab.com/samba-team/devel/samba 

repo (via SSH, URL is in the tool like on github).  Please start
branches with your username.

There a CI job will run and you can get see the output here:

https://gitlab.com/samba-team/devel/samba/pipelines

My experience is that once routinely pushing to GitLab become second-
nature, Samba development becomes smoother. 

Finally, could we have a bit more of a rationale (for those wondering
in a few years why this was flipped) and a patch to the WHATSNEW?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba