[PATCH] don't enable wins dns proxying by default

Andrew Bartlett abartlet at samba.org
Tue Jun 26 08:14:31 UTC 2018


On Tue, 2018-06-26 at 09:53 +0200, Björn JACKE via samba-technical
wrote:
> On 2018-06-26 at 05:39 +1200 Andrew Bartlett via samba-technical sent off:
> > On Mon, 2018-06-25 at 13:31 +0200, Björn JACKE via samba-technical
> > wrote:
> > > please review and push eventually
> > 
> > Now I realise you are just trying to provoke a discussion,
> 
> I have no idea what you mean with that, can you write in better words?
> 
> 
> > but I would
> > have expected a default value change to need to have the smb.conf
> > manpage updated and the source3 defaults changed. 
> 
> the man page is updated automatically along with the default parameters IIRC,
> if for some reason it is not in this case, let me know, I'd be happy to fix
> that then
> 
> > (The tests should have picked this up, if you did a test run please let
> > me know so we can investigate).
> 
> "the test should have picked this up" - again I don't get what you want to say.

G'Day Björn,

Perhaps submit the patch to the GitLab CI and see what happens. 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list