[PATCH] Fix demote of a Windows AD DC

Andrew Bartlett abartlet at samba.org
Tue Jun 26 05:00:33 UTC 2018


On Tue, 2018-06-26 at 16:42 +1200, Tim Beale via samba-technical wrote:
> Hi,
> 
> The attached patch fixed up a problem I noticed while testing the
> backup/restore tool against a Windows VM DC. Windows has an extra
> 'CN=DNS Settings' child object underneath the Server object that Samba
> doesn't have. This was causing the removal of the server object in the
> demote/remove_dc code to fail.
> 
> This should hopefully fix the problem reported on the samba mailing list:
> https://lists.samba.org/archive/samba/2018-June/216572.html
> 
> CI tests link (in progress).
> https://gitlab.com/catalyst-samba/samba/pipelines/24561455
> 
> Review appreciated.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list