[PATCH] Make AD DC build require Jannsson JSON libs, fix fileserver without it

[Ralph Böhme]

On Mon, Jun 25, 2018 at 06:14:38AM +1200, Andrew Bartlett wrote:
> On Sat, 2018-06-23 at 16:15 +0200, Ralph Böhme wrote:
> > On Sat, Jun 23, 2018 at 10:05:00AM +1200, Andrew Bartlett wrote:
> > > On Fri, 2018-06-22 at 13:57 -0700, Jeremy Allison wrote:
> > > I spent around three hours yesterday building the patch attached, which
> > > I could have spent on other things if we had just accepted it as a
> > > build requirement overall.
> > 
> > ENOPATCH?
> 
> The patch was at the top of the thread, attached here for your
> enjoyment. 

pushed, for your enjoyment.

> This is exactly it.  Perhaps you and I will have different weights for
> 'a big maintenance burden', and you will see I certainly understand the
> AD and file-server use cases differ, but please bear with me:

no, I don't see a difference.

> ...
>
> In doing that I made my proposal, not previously discussed, to lock in
> the (new) status quo for the AD DC (Jannsson required), but to relax
> the requirement for the fileserver (make Jannsson optional for --
> without-ad-dc even with --enable-selftest). 

sorry, still not convinced. Skimming through lib/audit_logging/ and friends it
just seems to lack proper abstraction.

If you really think this is direciton, by all means, let's move ahead. I'm not a
AD stake-holder, metze is ooo, Jeremy ACKed, so let's move on.

Can you please update

https://wiki.samba.org/index.php/Package_Dependencies_Required_to_Build_Samba

and WHATSNEW for 4.9? Thanks!

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46