[PATCH] Make AD DC build require Jannsson JSON libs, fix fileserver without it

[Jeremy Allison]

On Fri, Jun 22, 2018 at 10:43:08PM +0200, Ralph Böhme wrote:
> On Fri, Jun 22, 2018 at 10:49:00AM -0700, Jeremy Allison wrote:
> > On Fri, Jun 22, 2018 at 07:35:45PM +0200, Ralph Böhme wrote:
> > > hm, I disagree. I strongly feel that it doesn't add too much upstream
> > > maintanance having a --without-json-audit switch that allows building on older
> > > systems that are lacking libjansson.
> > 
> > Yeah but it's json today, it'll be something else tomorrow.
> 
> Nah, today is today and tomorrow is tomorrow. Today, RHEL 6 is still a supported
> release and will be til 2020. Or am I missing something?
> 
> > IMHO I think it's OK for the AD-DC to require more packages/resources
> > than a fileserver build.
> 
> sorry, but I don't get it. Why is json audit logging a *requirement*? It might
> be a required features for some downstream consumers, it certainly it not a
> requirement for all, is it?

Well the auditing is a big deal for customers using an AD-DC.
Many laws around compliance require proper auditing. We have
it in the fileserver already (vfs_audit etc.), the AD-DC needs
it too.

Happens that the auditing code in the AD-DC requires json. I
didn't write it that way but IMHO it's a reasonable technical
decision.

> > It's a big complex beast that does a lot of stuff, and it's
> > still rapidly under development with more features being added.
> > 
> > If we try and make it compatible with only the packages available
> > on 8+ year old distro's we're going to make development more complex
> > than it already is.
> 
> Hm, how much work can it be maintaining a build without libjansson? 

Well IMHO this isn't just around json. We can probably maintain
such a build. It's more around can we freely develop an AD-DC
requiring technologies that aren't packed by default in a distro
from 2010 ?

I think that's too old for requirements. What do others think
about the minimum/maximum distro age we should support out of
the box ?

Jeremy.