[PATCH] Make AD DC build require Jannsson JSON libs, fix fileserver without it

[Ralph Böhme]

On Fri, Jun 22, 2018 at 09:44:32AM -0700, Jeremy Allison via samba-technical wrote:
> On Fri, Jun 22, 2018 at 04:04:18PM +0200, Björn Baumbach wrote:
> > On 06/21/2018 09:00 PM, Andrew Bartlett via samba-technical wrote:
> > > On Thu, 2018-06-21 at 12:56 +0200, Volker Lendecke wrote:
> > >> Hi, Andrew!
> > >>
> > >> ./configure --prefix=/root/vlendec/inst --without-ldb-lmdb --without-json-audit --without-gpgme --without-libarchive
> > >>
> > >> leads to
> > >> What am I doing wrong? Am I missing another configure switch?
> > > No, but I think we should just require it for the DC. 
> > 
> > Hi!
> > 
> > I do not like the idea to enforce the libjansson as a requirement to
> > build the Samba AD DC code.
> > 
> > I've added the --without-json-audit, because there are several systems
> > where the jansson json libraries are not avaiable - at least not in the
> > standard repositories.
> > 
> > I've just looked into the RHEL 6 and SLES 11 repositories - there is no
> > libjansson available. Even SLES 11 and RHEL 6 are supported systems for
> > the next 4 and 6 years. I would not like to loose the option to build a
> > recent Samba AD DC on those systems.
> 
> I don't want the AD-DC code to be held back to the
> requirements of much older systems. I'm OK with the
> AD-DC requiring json for the auditing, so long as it's
> no needed for the fileserver at the moment.

hm, I disagree. I strongly feel that it doesn't add too much upstream
maintanance having a --without-json-audit switch that allows building on older
systems that are lacking libjansson.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46