Witness service - s3 asynchronous RPC server

Andreas Schneider asn at samba.org
Fri Jun 22 07:59:01 UTC 2018

On Friday, 22 June 2018 09:27:41 CEST Samuel Cabrero via samba-technical 
> Hi,

Hi Samuel,
> Before going further, I think the "s3" RPC server patch has to be
> reviewed and pushed, so I send it here requesting for comments.

I think Metze needs to look into this, as he is the DCERPC expert (probably he 
is the expert for everything).

However, the patches are from Dave, so they need to be Signed-off by Dave!! If 
you have helped to write them, you should add:

Pair-Programmed-With: Samuel Cabrero ...
Signed-off-by: David Disseldorp ...
Signed-off-by: Samuel Cabrero ...

If you just reviewed them, please add:

Reviewed-by: Samuel Cabrero ...

after the Signed-off-by from Dave :-) See other commits in the Samba git tree.

Please make sure that in new code pointers are initialized with NULL and 
please use TALLOC_FREE instead of talloc_free().

Also it is easier for us to handle patches if you attach them as a single big 

git format-patch --stdout -13 > one.patch.txt



Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D

More information about the samba-technical mailing list