[RFC] Performance improvements

Stefan Metzmacher metze at samba.org
Thu Jun 21 14:37:00 UTC 2018

Hi Swen,

> On Wed, 2018-06-20 at 15:09 -0700, Jeremy Allison wrote:
>> On Wed, Jun 20, 2018 at 10:51:58PM +0200, Swen Schillig wrote:
>>> Therefore, I would really like you to have a look at the code again
>>> and
>>> "verify" if the changes are as evil as you claim.
>> You do have some integer wrap and variable type
>> work to do first - so why not do that and then resubmit
>> with the "questionable" patch as the last entry
>> so it can be reviewed carefully individually ?

I'd also avoid the change that removes the immediate event.
Typically the state might be gone after calling a callback
function and we should call 'return' directly without touching
any variables at all. The callback could destroy the queue!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180621/129b0feb/signature.sig>

More information about the samba-technical mailing list